Partially revert "stream: reduce internal usage of public require of util" #29475
Conversation
…util" This partially reverts commit c97851d. Streams code should ideally require on public APIs as much as possible, because it is exported as readable-stream. Refs: nodejs#26698 Refs: nodejs/readable-stream#416
nodejs-github-bot
added
the
stream
|
@bmeck It should make maintaining readable-stream easier, and it makes the fallback code in If that isn’t an acceptable reason for this PR in your eyes, please close it, as I don’t think it’s worth spending much time arguing about this relatively minor change. |
|
@addaleax I don't exactly understand how this works, because the code in |
|
@addaleax I think thats fine, just please add a disclaimer somewhere to that effect in the actual file itself to prevent some thrashing we are seeing on moving things between internal/public APIs. I would like to PR removing code for various fallback types like |
|
Hm right, it looks like the fallback code in |
|
Yes, it’s not used in the active line. You can remove it. |
The fallback code is no longer used when exporting to readable-stream. Refs: nodejs#29475
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
The fallback code is no longer used when exporting to readable-stream. Refs: #29475 PR-URL: #29514 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This partially reverts commit c97851d.
Streams code should ideally require on public APIs as much as possible,
because it is exported as readable-stream.
Refs: #26698
Refs: nodejs/readable-stream#416
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes